[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 14/19] apic: do not dereference pointer before it is
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PULL 14/19] apic: do not dereference pointer before it is checked for NULL |
Date: |
Mon, 26 Jan 2015 10:24:25 +0100 |
Right now you only get to apic_init_reset if you have an APIC
(do_cpu_init is reached only if CPU_INTERRUPT_INIT is set and
that only happens in hw/intc/apic.c). However, this is wrong
because for example a port 92 or keyboard controller reset is
really an INIT, and that can happen also with no APIC. So
keep the check and fix the error that Coverity reported.
Reported-by: Markus Armbruster <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
---
hw/intc/apic_common.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/hw/intc/apic_common.c b/hw/intc/apic_common.c
index d9bb188..0858b45 100644
--- a/hw/intc/apic_common.c
+++ b/hw/intc/apic_common.c
@@ -177,13 +177,14 @@ bool apic_next_timer(APICCommonState *s, int64_t
current_time)
void apic_init_reset(DeviceState *dev)
{
- APICCommonState *s = APIC_COMMON(dev);
- APICCommonClass *info = APIC_COMMON_GET_CLASS(s);
+ APICCommonState *s;
+ APICCommonClass *info;
int i;
- if (!s) {
+ if (!dev) {
return;
}
+ s = APIC_COMMON(dev);
s->tpr = 0;
s->spurious_vec = 0xff;
s->log_dest = 0;
@@ -208,6 +209,7 @@ void apic_init_reset(DeviceState *dev)
}
s->timer_expiry = -1;
+ info = APIC_COMMON_GET_CLASS(s);
if (info->reset) {
info->reset(s);
}
--
1.8.3.1
- [Qemu-devel] [PULL 00/19] i386, KVM, misc changes for 2015-01-26, Paolo Bonzini, 2015/01/26
- [Qemu-devel] [PULL 03/19] multiboot: Fix offset of bootloader name, Paolo Bonzini, 2015/01/26
- [Qemu-devel] [PULL 04/19] tests/multiboot: Add test for modules, Paolo Bonzini, 2015/01/26
- [Qemu-devel] [PULL 05/19] target-i386: use vmstate_offset_sub_array for AVX registers, Paolo Bonzini, 2015/01/26
- [Qemu-devel] [PULL 06/19] target-i386: make xmm_regs 512-bit wide, Paolo Bonzini, 2015/01/26
- [Qemu-devel] [PULL 01/19] pc: fix KVM features in pc-1.3 and earlier machine types, Paolo Bonzini, 2015/01/26
- [Qemu-devel] [PULL 07/19] qemu-timer: add timer_init and timer_init_ns/us/ms, Paolo Bonzini, 2015/01/26
- [Qemu-devel] [PULL 09/19] vmstate: accept QEMUTimer in VMSTATE_TIMER*, add VMSTATE_TIMER_PTR*, Paolo Bonzini, 2015/01/26
- [Qemu-devel] [PULL 02/19] tests/multiboot: Update reference output, Paolo Bonzini, 2015/01/26
- [Qemu-devel] [PULL 11/19] kvm_stat: Add aarch64 support, Paolo Bonzini, 2015/01/26
- [Qemu-devel] [PULL 14/19] apic: do not dereference pointer before it is checked for NULL,
Paolo Bonzini <=
- [Qemu-devel] [PULL 10/19] hw: misc, add educational driver, Paolo Bonzini, 2015/01/26
- [Qemu-devel] [PULL 15/19] .travis.yml: Add "--enable-modules", Paolo Bonzini, 2015/01/26
- [Qemu-devel] [PULL 08/19] qemu-timer: introduce timer_deinit, Paolo Bonzini, 2015/01/26
- [Qemu-devel] [PULL 17/19] sparse: Fix build with sparse on .S files, Paolo Bonzini, 2015/01/26
- [Qemu-devel] [PULL 19/19] kvm_stat: Add RESET support for perf event ioctl, Paolo Bonzini, 2015/01/26
- [Qemu-devel] [PULL 12/19] kvm_stat: Update exit reasons to the latest defintion, Paolo Bonzini, 2015/01/26
- [Qemu-devel] [PULL 16/19] exec: fix madvise of NULL pointer, Paolo Bonzini, 2015/01/26
- [Qemu-devel] [PULL 13/19] kvm_stat: Print errno when syscall to perf_event_open() fails, Paolo Bonzini, 2015/01/26
- [Qemu-devel] [PULL 18/19] target-i386: Disable HLE and RTM on Haswell & Broadwell, Paolo Bonzini, 2015/01/26
- Re: [Qemu-devel] [PULL 00/19] i386, KVM, misc changes for 2015-01-26, Peter Maydell, 2015/01/26