[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qemu-timer.c: Trim list of included headers
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH] qemu-timer.c: Trim list of included headers |
Date: |
Mon, 26 Jan 2015 18:31:36 +0000 |
On 20 January 2015 at 16:17, Paolo Bonzini <address@hidden> wrote:
>
>
> On 20/01/2015 17:16, Peter Maydell wrote:
>> qemu-timer.c was including a lot more headers than it needed to,
>> presumably for historical reasons. In particular, it included
>> ui/console.h; this now tries to pull in <pixman.h>, which will
>> cause a compilation failure in --disable-tools --disable-system
>> configurations when running "make check" (which builds qemu-timer.c,
>> even though the linux-user binaries themselves don't need it).
>>
>> Fix this build failure by trimming down the set of included
>> headers severely -- we only really need main-loop.h and timer.h.
>>
>> Signed-off-by: Peter Maydell <address@hidden>
> Reviewed-by: Paolo Bonzini <address@hidden>
Thanks; applied to master as a buildfix.
-- PMM