Re: [Qemu-devel] [PATCH v5 2/5] qtest: Add scripts/qtest.py

[Max Reitz]

On 2015-01-16 at 03:46, Fam Zheng wrote:
> This adds scripts/qtest.py as a python library for qtest protocol.
>
> This is a skeleton with a basic "cmd" method to execute a command,
> reading and parsing of qtest output could be added later on demand.
>
> Signed-off-by: Fam Zheng <address@hidden>
> ---
>   scripts/qtest.py | 71 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>   1 file changed, 71 insertions(+)
>   create mode 100644 scripts/qtest.py
>
> diff --git a/scripts/qtest.py b/scripts/qtest.py
> new file mode 100644
> index 0000000..25391f5
> --- /dev/null
> +++ b/scripts/qtest.py
> @@ -0,0 +1,71 @@
> +# QEMU qtest library
> +#
> +# Copyright (C) 2015 Red Hat Inc.
> +#
> +# Authors:
> +#  Fam Zheng <address@hidden>
> +#
> +# This work is licensed under the terms of the GNU GPL, version 2.  See
> +# the COPYING file in the top-level directory.
> +#
> +# Based on qmp.py.
> +#
> +
> +import errno
> +import socket
> +
> +class QEMUQtestProtocol(object):
> +    def __init__(self, address, server=False):
> +        """
> +        Create a QEMUQtestProtocol object.
> +
> +        @param address: QEMU address, can be either a unix socket path (string)
> +                        or a tuple in the form ( address, port ) for a TCP
> +                        connection
> +        @param server: server mode listens on the socket (bool)

Maybe you could add a comma here ("server mode, listens...").

With or without:

Reviewed-by: Max Reitz <address@hidden>