Re: [Qemu-devel] [PATCH v3 06/14] qemu-img: Use blk_new_open() in img_rebase()

[Eric Blake]

On 01/26/2015 08:00 AM, Max Reitz wrote:
> Signed-off-by: Max Reitz <address@hidden>
> ---
>  qemu-img.c | 57 ++++++++++++++++++++++++---------------------------------
>  1 file changed, 24 insertions(+), 33 deletions(-)
> 

> -
>      /* For safe rebasing we need to compare old and new backing file */
>      if (!unsafe) {
>          char backing_name[PATH_MAX];
> +        QDict *options = NULL;
> +
> +        if (!unsafe && bs->backing_format[0] != '\0') {

Useless conditional ('!unsafe' is always true here).

With that fixed,
Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature