Re: [Qemu-devel] [PATCH] block: Simplify a few g_try_malloc() error checks

[Paolo Bonzini]

On 27/01/2015 13:25, Markus Armbruster wrote:
> Unlike malloc(), g_try_malloc() & friends return a null pointer only
> on failure, never for a zero size.  Simplify tests for failure
> accordingly.  This helps Coverity see returned null pointers can't be
> dereferenced.  Also makes the code easier to read.

Unfortunately that's not what I see from the source:

gpointer
g_try_malloc (gsize n_bytes)
{
  gpointer mem;

  if (G_LIKELY (n_bytes))
    mem = glib_mem_vtable.try_malloc (n_bytes);
  else
    mem = NULL;

  TRACE (GLIB_MEM_ALLOC((void*) mem, (unsigned int) n_bytes, 0, 1));

  return mem;
}

Paolo