Re: [Qemu-devel] [PATCH 5/6] vnc: g_realloc() can't fail, bury dead error handling

[Thomas Huth]

On Tue, 27 Jan 2015 17:38:30 +0100
Markus Armbruster <address@hidden> wrote:

> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>  ui/vnc.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/ui/vnc.c b/ui/vnc.c
> index a742c90..02552ee 100644
> --- a/ui/vnc.c
> +++ b/ui/vnc.c
> @@ -659,10 +659,6 @@ void buffer_reserve(Buffer *buffer, size_t len)
>      if ((buffer->capacity - buffer->offset) < len) {
>          buffer->capacity += (len + 1024);
>          buffer->buffer = g_realloc(buffer->buffer, buffer->capacity);
> -        if (buffer->buffer == NULL) {
> -            fprintf(stderr, "vnc: out of memory\n");
> -            exit(1);
> -        }
>      }
>  }
> 

Reviewed-by: Thomas Huth <address@hidden>