[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] pc: memory: Validate alignment of maxram_si
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH 2/2] pc: memory: Validate alignment of maxram_size to page size |
|
Date: |
Tue, 27 Jan 2015 11:16:26 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
On 01/26/2015 08:31 AM, Peter Krempa wrote:
> If the maxram_size is not aligned and dimm devices were added on the
> command line qemu would terminate with a rather unhelpful message:
>
> ERROR:hw/mem/pc-dimm.c:150:pc_dimm_get_free_addr: assertion failed:
> (QEMU_ALIGN_UP(address_space_size, align) == address_space_size)
>
> In case no dimm device was originally added on the commandline qemu
> exits on the assertion failure.
>
> Signed-off-by: Peter Krempa <address@hidden>
> ---
> hw/i386/pc.c | 7 +++++++
> 1 file changed, 7 insertions(+)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature