Re: [Qemu-devel] [PATCH 02/50] iotests: Only create BB if necessary

[Eric Blake]

On 01/26/2015 09:02 AM, Max Reitz wrote:
> Tests 071 and 081 test giving references in blockdev-add. It is not
> necessary to create a BlockBackend here, so omit it.
> 
> Signed-off-by: Max Reitz <address@hidden>
> ---
>  tests/qemu-iotests/071     | 50 
> ++++++++++++++++++++++++++++++++++++++++++----
>  tests/qemu-iotests/071.out | 12 +++++++----
>  tests/qemu-iotests/081     | 14 ++++++++++++-
>  tests/qemu-iotests/081.out |  5 +++--
>  4 files changed, 70 insertions(+), 11 deletions(-)
> 

Reviewed-by: Eric Blake <address@hidden>

but given my comments in 1/50, you'll want to also add a test somewhere
(either there or here) that omitting both id and node-name gives an error.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature