Re: [Qemu-devel] [PATCH 07/50] block: Make bdrv_is_inserted() recursive

[Eric Blake]

On 01/26/2015 09:02 AM, Max Reitz wrote:
> If bdrv_is_inserted() is called on the top level BDS, it should make
> sure all nodes in the BDS tree are actually inserted.
> 
> Signed-off-by: Max Reitz <address@hidden>
> ---
>  block.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 

> +    return (!drv->bdrv_is_inserted || drv->bdrv_is_inserted(bs)) &&
> +           (!bs->file              || bdrv_is_inserted(bs->file)) &&
> +           (!bs->backing_hd        || bdrv_is_inserted(bs->backing_hd));

Hopefully we never allow ejecting a backing file while the active file
is still present, but that doesn't affect the correctness of this patch.

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature