Re: [Qemu-devel] [PATCH RESEND 11/50] block: Move BlockAcctStats into BlockBackend

[Eric Blake]

[replies to earlier patches in the other thread; moving the rest of my
review here for the sake of improved cc]

On 01/27/2015 12:45 PM, Max Reitz wrote:
> As the comment above bdrv_get_stats() says, BlockAcctStats is something
> which belongs to the device instead of each BlockDriverState. This patch
> therefore moves it into the BlockBackend.
> 
> Signed-off-by: Max Reitz <address@hidden>
> ---
>  block.c                   | 11 -----------
>  block/block-backend.c     |  5 ++++-
>  block/qapi.c              | 20 ++++++++++++--------
>  include/block/block.h     |  2 --
>  include/block/block_int.h |  3 ---
>  5 files changed, 16 insertions(+), 25 deletions(-)
> 

Reviewed-by: Eric Blake <address@hidden>

(I spent some time hunting to ensure that 0-initialized stats make sense
when there is no BB - libvirt returns -1 rather than 0 for some stats,
but it's always a pain to remember which stats have the special treatment)

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature