[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH v1 06/13] spapr: CPU hotplug support
From: |
Michael Roth |
Subject: |
Re: [Qemu-devel] [RFC PATCH v1 06/13] spapr: CPU hotplug support |
Date: |
Tue, 27 Jan 2015 23:41:19 -0600 |
User-agent: |
alot/0.3.4 |
Quoting Bharata B Rao (2015-01-27 22:19:56)
> On Thu, Jan 22, 2015 at 04:16:01PM -0600, Michael Roth wrote:
> > Quoting Bharata B Rao (2015-01-08 00:10:13)
> > > +static void spapr_machine_device_plug(HotplugHandler *hotplug_dev,
> > > + DeviceState *dev, Error **errp)
> > > +{
> > > + if (object_dynamic_cast(OBJECT(dev), TYPE_CPU)) {
> > > + if (dev->hotplugged) {
> >
> > Maybe just
> >
> > if (dev->hotplugged && spapr->dr_cpu_enabled) {
> > ...
> >
> > Would do it
>
> This is a common ->plug() handler and would be used for memory too. Hence
> there is a need to identify the type of object (CPU or memory) and handle it
> differently.
I mean in terms of the "/* TODO: Check if DR is enabled ? */". Adding this
check here, as well as during spapr_dr_connector_new(), should cover all
the cases where the value needs to be checked AFAICT.
>
> Regards,
> Bharata.
- [Qemu-devel] [RFC PATCH v1 12/13] spapr: Support ibm, dynamic-reconfiguration-memory, (continued)
- [Qemu-devel] [RFC PATCH v1 12/13] spapr: Support ibm, dynamic-reconfiguration-memory, Bharata B Rao, 2015/01/08
- [Qemu-devel] [RFC PATCH v1 09/13] spapr: CPU hot unplug support, Bharata B Rao, 2015/01/08
- [Qemu-devel] [RFC PATCH v1 02/13] spapr: Add DRC dt entries for CPUs, Bharata B Rao, 2015/01/08
- [Qemu-devel] [RFC PATCH v1 06/13] spapr: CPU hotplug support, Bharata B Rao, 2015/01/08
- Re: [Qemu-devel] [RFC PATCH v1 06/13] spapr: CPU hotplug support, Igor Mammedov, 2015/01/23
- Re: [Qemu-devel] [RFC PATCH v1 06/13] spapr: CPU hotplug support, David Gibson, 2015/01/28
- [Qemu-devel] [RFC PATCH v1 10/13] cpus, spapr: reclaim allocated vCPU objects, Bharata B Rao, 2015/01/08
Re: [Qemu-devel] [RFC PATCH v1 00/13] CPU and Memory hotplug for PowerPC guests, Andreas Färber, 2015/01/29
Re: [Qemu-devel] [RFC PATCH v1 00/13] CPU and Memory hotplug for PowerPC guests, Tyrel Datwyler, 2015/01/29