[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] linux-user/syscall.c: Let all lock_user_struct(
From: |
Riku Voipio |
Subject: |
Re: [Qemu-devel] [PATCH] linux-user/syscall.c: Let all lock_user_struct() and unlock_user_struct() paired with each other |
Date: |
Wed, 28 Jan 2015 16:27:05 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Hi,
First of all, thanks Chen for taking time to improve the linux-user
codebase in qemu!
On Mon, Jan 26, 2015 at 03:01:52PM +0000, Peter Maydell wrote:
> On 26 January 2015 at 14:59, Chen Gang S <address@hidden> wrote:
> > On 1/26/15 06:10, Peter Maydell wrote:
> >> I would just like the commit message to be clear about the
> >> scope of the work the patch covers. If the patch is just "Fix
> >> mismatched lock/unlock calls in IPC struct conversion functions"
> >> then that's fine, but the commit message should say that. At the
> >> moment the commit message is very vague.
> >>
> >
> > OK, thanks.
> >
> > I am not quite familiar with this file, so I describe the modification
> > by function name, e.g. lock_user_struct() and unlick_user_struct() in
> > the patch subject.
> In a big file I think it's often more useful to describe the
> functions which are being changed. My suggested subject would be:
> "Fix mismatched lock/unlock calls in IPC struct conversion functions"
> Riku can decide if he wants a v2 or will just fix it up as he
> applies it to his linux-user tree.
No need for v2, I've change the title in my tree.
Riku
- [Qemu-devel] [PATCH] linux-user/syscall.c: Let all lock_user_struct() and unlock_user_struct() paired with each other, Chen Gang S, 2015/01/25
- Re: [Qemu-devel] [PATCH] linux-user/syscall.c: Let all lock_user_struct() and unlock_user_struct() paired with each other, Peter Maydell, 2015/01/25
- Re: [Qemu-devel] [PATCH] linux-user/syscall.c: Let all lock_user_struct() and unlock_user_struct() paired with each other, Chen Gang S, 2015/01/25
- Re: [Qemu-devel] [PATCH] linux-user/syscall.c: Let all lock_user_struct() and unlock_user_struct() paired with each other, Peter Maydell, 2015/01/25
- Re: [Qemu-devel] [PATCH] linux-user/syscall.c: Let all lock_user_struct() and unlock_user_struct() paired with each other, Chen Gang S, 2015/01/26
- Re: [Qemu-devel] [PATCH] linux-user/syscall.c: Let all lock_user_struct() and unlock_user_struct() paired with each other, Peter Maydell, 2015/01/26
- Re: [Qemu-devel] [PATCH] linux-user/syscall.c: Let all lock_user_struct() and unlock_user_struct() paired with each other, Chen Gang S, 2015/01/26
- Re: [Qemu-devel] [PATCH] linux-user/syscall.c: Let all lock_user_struct() and unlock_user_struct() paired with each other,
Riku Voipio <=
- Re: [Qemu-devel] [PATCH] linux-user/syscall.c: Let all lock_user_struct() and unlock_user_struct() paired with each other, Chen Gang S, 2015/01/28
- Re: [Qemu-devel] [PATCH] linux-user/syscall.c: Let all lock_user_struct() and unlock_user_struct() paired with each other, Peter Maydell, 2015/01/28
- Re: [Qemu-devel] [PATCH] linux-user/syscall.c: Let all lock_user_struct() and unlock_user_struct() paired with each other, Chen Gang S, 2015/01/28