|
From: | Max Reitz |
Subject: | Re: [Qemu-devel] [PATCH RESEND 22/50] blockdev: Check BB validity in drive-backup TA |
Date: | Wed, 28 Jan 2015 11:27:36 -0500 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
On 2015-01-27 at 18:44, Eric Blake wrote:
On 01/27/2015 12:45 PM, Max Reitz wrote:In the drive-backup transaction, call blk_is_available() before using blk_bs() to obtain the root BlockDriverState behind the BlockBackend.Took me a while to figure that TA meant transaction in the subject. Either spell it out, or just drop 'TA' entirely (the shorter subject would still make sense). (21/50 as well).
Well, the subject would then be the same as for 26. drive-backup is something different than the drive-backup transaction.
I don't really have a problem with using longer subjects lines, but vim tells me not to. :-( However, vim hasn't passed the turing test, so if you tell me to I'll ignore it.
Max
Signed-off-by: Max Reitz <address@hidden> --- blockdev.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-)Reviewed-by: Eric Blake <address@hidden>
[Prev in Thread] | Current Thread | [Next in Thread] |