[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RESEND 34/50] blockdev: Do not create BDS for em
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH RESEND 34/50] blockdev: Do not create BDS for empty drive |
Date: |
Wed, 28 Jan 2015 10:50:50 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
On 01/27/2015 12:46 PM, Max Reitz wrote:
> Do not use "rudimentary" BDSs for empty drives any longer (for
> freshly created drives).
>
> With this change, bdrv_close_all() has no effect on empty drives (whose
> media were not changed) any longer. This breaks some test outputs, fix
> them.
>
> After a follow-up patch, empty drives will generally use a NULL BDS, not
> only the freshly created drives.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> blockdev.c | 68
> ++++++++++++++++++++++++++--------------------
> tests/qemu-iotests/067.out | 44 ------------------------------
> tests/qemu-iotests/071.out | 2 --
> tests/qemu-iotests/081.out | 1 -
> tests/qemu-iotests/087.out | 5 ----
> 5 files changed, 38 insertions(+), 82 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH RESEND 30/50] blockdev: Check BB validity in change-backing-file, (continued)
- [Qemu-devel] [PATCH RESEND 30/50] blockdev: Check BB validity in change-backing-file, Max Reitz, 2015/01/27
- [Qemu-devel] [PATCH RESEND 28/50] blockdev: Check BB validity in drive-mirror, Max Reitz, 2015/01/27
- [Qemu-devel] [PATCH RESEND 31/50] block: Add blk_insert_bs(), Max Reitz, 2015/01/27
- [Qemu-devel] [PATCH RESEND 32/50] blockdev: Check BB validity in eject and change, Max Reitz, 2015/01/27
- [Qemu-devel] [PATCH RESEND 34/50] blockdev: Do not create BDS for empty drive, Max Reitz, 2015/01/27
- Re: [Qemu-devel] [PATCH RESEND 34/50] blockdev: Do not create BDS for empty drive,
Eric Blake <=
- [Qemu-devel] [PATCH RESEND 36/50] blockdev: Allow more options for BB-less BDS tree, Max Reitz, 2015/01/27
- [Qemu-devel] [PATCH RESEND 38/50] blockdev: Add blockdev-open-tray, Max Reitz, 2015/01/27
- [Qemu-devel] [PATCH RESEND 33/50] blockdev: Respect NULL BDS in do_drive_del(), Max Reitz, 2015/01/27
- [Qemu-devel] [PATCH RESEND 39/50] blockdev: Add blockdev-close-tray, Max Reitz, 2015/01/27