Re: [Qemu-devel] [PATCH RESEND 49/50] iotests: More options for VM.add_drive()

[Eric Blake]

On 01/27/2015 12:46 PM, Max Reitz wrote:
> This patch allows specifying the interface to be used for the drive, and
> makes specifying a path optional (if the path is None, the "file" option
> will be omitted, thus creating an empty drive).
> 
> Signed-off-by: Max Reitz <address@hidden>
> ---
>  tests/qemu-iotests/iotests.py | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 

> +
> +        if not path is None:
> +            options.append('file=%s' % path)

Works, but it is more idiomatic to use 'if path is not None:', based on
a grep of the source tree.

With that minor switch,
Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature