Re: [Qemu-devel] [PATCH RESEND 49/50] iotests: More options for VM.add_drive()

[Eric Blake]

On 01/28/2015 02:28 PM, Max Reitz wrote:
> On 2015-01-28 at 16:27, Eric Blake wrote:
>> On 01/27/2015 12:46 PM, Max Reitz wrote:
>>> This patch allows specifying the interface to be used for the drive, and
>>> makes specifying a path optional (if the path is None, the "file" option
>>> will be omitted, thus creating an empty drive).
>>>
>>> Signed-off-by: Max Reitz <address@hidden>
>>> ---
>>>   tests/qemu-iotests/iotests.py | 9 ++++++---
>>>   1 file changed, 6 insertions(+), 3 deletions(-)
>>>
>>> +
>>> +        if not path is None:
>>> +            options.append('file=%s' % path)
>> Works, but it is more idiomatic to use 'if path is not None:', based on
>> a grep of the source tree.
> 
> Did I ever mention I don't know Python very well?

The feeling is mutual.  So it's the blind leading the blind :)

> 
> That sounds a lot better, will do, thanks.
> 
>> With that minor switch,
>> Reviewed-by: Eric Blake <address@hidden>
> 
> On to the last patch! :-)
> 
> Max
> 
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature