[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 02/21] quorum: Fix close path
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 02/21] quorum: Fix close path |
Date: |
Wed, 28 Jan 2015 15:16:48 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
On 01/26/2015 12:27 PM, Max Reitz wrote:
> bdrv_unref() can lead to bdrv_close(), which in turn will result in
> bdrv_drain_all(). This function will later be called blk_drain_all() and
> iterate only over the BlockBackends for which blk_is_inserted() holds
> true; therefore, bdrv_is_inserted() and thus quorum_is_inserted() will
> probably be called.
>
> This patch makes quorum_is_inserted() aware of the fact that some
> children may have been closed already.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> block/quorum.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> for (i = 0; i < s->num_children; i++) {
> - if (!bdrv_is_inserted(s->bs[i])) {
> + if (s->bs[i] && !bdrv_is_inserted(s->bs[i])) {
> return 0;
May have a minor conflict if you fix the earlier series to use bool for
this function's return type. But that should not get in the way of:
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH 04/21] block: Add bdrv_close_all() handlers, (continued)
Re: [Qemu-devel] [PATCH 04/21] block: Add bdrv_close_all() handlers, Eric Blake, 2015/01/28
[Qemu-devel] [PATCH 05/21] block: Remove per-BDS close notifiers, Max Reitz, 2015/01/26
[Qemu-devel] [PATCH 10/21] block: Add blk_next_inserted(), Max Reitz, 2015/01/26
[Qemu-devel] [PATCH 02/21] quorum: Fix close path, Max Reitz, 2015/01/26
- Re: [Qemu-devel] [PATCH 02/21] quorum: Fix close path,
Eric Blake <=
[Qemu-devel] [PATCH 14/21] blockdev: Remove blk_hide_on_behalf_of_do_drive_del(), Max Reitz, 2015/01/26
[Qemu-devel] [PATCH 16/21] block: Move some bdrv_*_all() functions to BB, Max Reitz, 2015/01/26
[Qemu-devel] [PATCH 12/21] block: Use BlockBackend more, Max Reitz, 2015/01/26
[Qemu-devel] [PATCH 15/21] block: Make bdrv_drain_one() public, Max Reitz, 2015/01/26
[Qemu-devel] [PATCH 11/21] block: Add blk_commit_all() and blk_invalidate_cache_all(), Max Reitz, 2015/01/26
[Qemu-devel] [PATCH 17/21] block: Remove bdrv_states, Max Reitz, 2015/01/26