[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] vnc: fix qemu crash when not configure vnc
From: |
Gonglei |
Subject: |
Re: [Qemu-devel] [PATCH 1/3] vnc: fix qemu crash when not configure vnc option |
Date: |
Fri, 30 Jan 2015 08:37:05 +0800 |
User-agent: |
Mozilla/5.0 (Windows NT 6.1; rv:11.0) Gecko/20120327 Thunderbird/11.0.1 |
On 2015/1/30 0:14, Don Slutz wrote:
> On 01/29/15 07:52, address@hidden wrote:
>> From: Gonglei <address@hidden>
>>
>> Reproducer:
>> $ x86_64-softmmu/qemu-system-x86_64
>> qemu-system-x86_64: Invalid parameter 'to'
>> Segmentation fault (core dumped)
>>
>> Signed-off-by: Gonglei <address@hidden>
>> ---
>> ui/vnc.c | 9 +++++++++
>> 1 file changed, 9 insertions(+)
>>
>> diff --git a/ui/vnc.c b/ui/vnc.c
>> index a742c90..08b8b24 100644
>> --- a/ui/vnc.c
>> +++ b/ui/vnc.c
>> @@ -3276,6 +3276,15 @@ static QemuOptsList qemu_vnc_opts = {
>> .name = "connections",
>> .type = QEMU_OPT_NUMBER,
>> },{
>> + .name = "to",
>> + .type = QEMU_OPT_NUMBER,
>> + },{
>> + .name = "ipv4",
>> + .type = QEMU_OPT_BOOL,
>> + },{
>> + .name = "ipv6",
>> + .type = QEMU_OPT_BOOL,
>> + },{
>> .name = "password",
>> .type = QEMU_OPT_BOOL,
>> },{
>>
>
> The code change looks good, but does more then the commit message says.
>
> Maybe include something like "Add missing vnc options: to, ipv4, ipv6".
>
Will do, thanks.
Regards,
-Gonglei