Re: [Qemu-devel] [RFC PATCH v1 05/13] spapr: Support ibm, lrdr-capacity device tree property

[Bharata B Rao]

On Thu, Jan 29, 2015 at 12:16:09PM +1100, David Gibson wrote:
> On Thu, Jan 08, 2015 at 11:40:12AM +0530, Bharata B Rao wrote:
> > -int spapr_rtas_device_tree_setup(void *fdt, hwaddr rtas_addr,
> > -                                 hwaddr rtas_size)
> > +int spapr_rtas_device_tree_setup(sPAPREnvironment *spapr, void *fdt,
> > +                                 hwaddr rtas_addr, hwaddr rtas_size)
> >  {
> >      int ret;
> >      int i;
> > +    uint32_t lrdr_capacity[5];
> >  
> >      ret = fdt_add_mem_rsv(fdt, rtas_addr, rtas_size);
> >      if (ret < 0) {
> > @@ -604,6 +606,28 @@ int spapr_rtas_device_tree_setup(void *fdt, hwaddr 
> > rtas_addr,
> >          }
> >  
> >      }
> > +
> > +    ret = qemu_fdt_setprop_cell(fdt, "/rtas", "#address-cells", 0x2);
> > +    if (ret < 0) {
> > +        fprintf(stderr, "Couldn't add #address-cells rtas property\n");
> > +    }
> > +
> > +    ret = qemu_fdt_setprop_cell(fdt, "/rtas", "#size-cells", 0x2);
> > +    if (ret < 0) {
> > +        fprintf(stderr, "Couldn't add #size-cells rtas property\n");
> > +    }
> 
> It's not clear what adding #address-cells and #size-cells has to do
> with this, and these properties generally don't make sense on a node
> without children.

Yes, those aren't needed, will remove them.

Regards,
Bharata.