[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH v8 00/21] Deterministic replay core
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [RFC PATCH v8 00/21] Deterministic replay core |
Date: |
Fri, 30 Jan 2015 12:25:30 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
On 29/01/2015 11:21, Paolo Bonzini wrote:
>
>
> On 28/01/2015 12:45, Pavel Dovgaluk wrote:
>> Ping?
>
> Reviewed 13 patches out of 21. Made some comments, but overall I'm
> really pleased. Thanks for persisting!
>
> Will continue tomorrow.
The second part has a few more problems:
1) some simple and stylistic (patch 15, 19-21)
2) the invasive changes in patches 16-18 are, well, invasive. Lacking a
design and example document it is hard to review them. The block
maintainers, also, probably have better ideas of what to do.
3) A design document is also needed for checkpoints (patch 14)
Paolo
- [Qemu-devel] [RFC PATCH v8 18/21] replay: thread pool, (continued)
- [Qemu-devel] [RFC PATCH v8 18/21] replay: thread pool, Pavel Dovgalyuk, 2015/01/22
- [Qemu-devel] [RFC PATCH v8 19/21] replay: initialization and deinitialization, Pavel Dovgalyuk, 2015/01/22
- [Qemu-devel] [RFC PATCH v8 20/21] replay: command line options, Pavel Dovgalyuk, 2015/01/22
- [Qemu-devel] [RFC PATCH v8 21/21] replay: recording of the user input, Pavel Dovgalyuk, 2015/01/22
- Re: [Qemu-devel] [RFC PATCH v8 00/21] Deterministic replay core, Pavel Dovgaluk, 2015/01/28
- Message not available