Re: [Qemu-devel] [PATCH v2 2/4] blockdev: Eliminate silly QERR_BLOCK_JOB_NOT_ACTIVE macro

[Max Reitz]

On 2015-01-29 at 04:36, Markus Armbruster wrote:
> From: Markus Armbruster <address@hidden>

Intentional?

> The QERR_ macros are leftovers from the days of "rich" error objects.
> They're used with error_set() and qerror_report(), and expand into the
> first *two* arguments.  This trickiness has become pointless.  Clean
> this one up.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> ---
>   blockdev.c                | 3 ++-
>   include/qapi/qmp/qerror.h | 3 ---
>   2 files changed, 2 insertions(+), 4 deletions(-)

Reviewed-by: Max Reitz <address@hidden>