Re: [Qemu-devel] [PATCH] qemu-sockets: Fix buffer overflow in inet_parse()

[John Snow]

On 01/30/2015 02:37 PM, Kevin Wolf wrote:
> The size of the stack allocated host[] array didn't account for the
> terminating '\0' byte that sscanf() writes. Fix the array size.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>   util/qemu-sockets.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c
> index a76bb3c..aacf1fc 100644
> --- a/util/qemu-sockets.c
> +++ b/util/qemu-sockets.c
> @@ -512,7 +512,7 @@ InetSocketAddress *inet_parse(const char *str, Error **errp)
>   {
>       InetSocketAddress *addr;
>       const char *optstr, *h;
> -    char host[64];
> +    char host[65];
>       char port[33];
>       int to;
>       int pos;

You don't really need reviews for trivial, right?
*shrug*

Reviewed-by: John Snow <address@hidden>