[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 03/19] qtest/ahci: rename 'Command' to 'CommandH
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 03/19] qtest/ahci: rename 'Command' to 'CommandHeader' |
Date: |
Mon, 02 Feb 2015 11:25:05 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
On 30/01/2015 19:41, John Snow wrote:
> @@ -703,8 +703,8 @@ static void ahci_test_identify(AHCIQState *ahci)
> /* Copy the existing Command #0 structure from the CLB into local memory,
> * and build a new command #0. */
> memread(ahci->port[i].clb, &cmd, sizeof(cmd));
> - cmd.b1 = 5; /* reg_h2d_fis is 5 double-words long */
> - cmd.b2 = 0x04; /* clear PxTFD.STS.BSY when done */
> + cmd.flags = 5; /* reg_h2d_fis is 5 double-words long */
> + cmd.flags |= 0x400; /* clear PxTFD.STS.BSY when done */
Missing cpu_to_le16, I think.
Paolo
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH 03/19] qtest/ahci: rename 'Command' to 'CommandHeader',
Paolo Bonzini <=