[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 17/19] qtest/ahci: Add a macro bootup routine
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 17/19] qtest/ahci: Add a macro bootup routine |
Date: |
Mon, 02 Feb 2015 11:37:52 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
On 30/01/2015 19:42, John Snow wrote:
> +/**
> + * Boot and fully enable the HBA device.
> + * @see ahci_boot, ahci_pci_enable and ahci_hba_enable.
> + */
> +static AHCIQState *ahci_macro_bootup(void)
Ugly name... I would just leave out this patch.
Paolo
> +{
> + AHCIQState *ahci;
> + ahci = ahci_boot();
> +
> + ahci_pci_enable(ahci);
> + ahci_hba_enable(ahci);
> +
> + return ahci;
> +}
- Re: [Qemu-devel] [PATCH 17/19] qtest/ahci: Add a macro bootup routine,
Paolo Bonzini <=