[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC 09/10] cpu: remove exit_request global.
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [RFC 09/10] cpu: remove exit_request global. |
|
Date: |
Mon, 02 Feb 2015 14:14:19 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
On 02/02/2015 14:12, Peter Maydell wrote:
> > In particular, you can do it while you are under the big QEMU lock.
>
> ...but this is a signal handler, so we can't guarantee that the
> thread holds the big lock.
>
> ...and if we can iterate over CPU lists in signal handlers,
> the correct approach is probably to use the existing exit_request
> flag rather than adding another one. (Needs investigation to
> check and document semantics of that flag.)
I agree on both counts.
Paolo