Re: [Qemu-devel] [PULL 00/11] RCU, scsi, modules, icount changes for 2015-01-30

[Peter Maydell]

On 30 January 2015 at 15:19, Paolo Bonzini <address@hidden> wrote:
> The following changes since commit 83761b9244ad2ed39d3cfabe8a0e901ab906f7bf:
>
>   Merge remote-tracking branch 'remotes/riku/tags/pull-linux-user-20150127' 
> into staging (2015-01-27 22:25:56 +0000)
>
> are available in the git repository at:
>
>
>   git://github.com/bonzini/qemu.git tags/for-upstream
>
> for you to fetch changes up to 379e1ffb72c1feb7bd94467eb467351895afdcf2:
>
>   configure: Default to enable module build (2015-01-28 11:29:04 +0100)

I'm afraid configure barfs:
make: Entering directory `/home/petmay01/linaro/qemu-for-merges/build/alldbg'
config-host.mak is out-of-date, running configure
../../configure: 2736: local: -I/usr/include/glib-2.0: bad variable name
make: *** [config-host.mak] Error 2

I think this is insufficient quoting, so
    local probe_cflags=$($pkg_config --cflags $1)
    local probe_libs=$($pkg_config --libs $1)

break if the output of pkg_config contains spaces.

(Strictly speaking "local" isn't POSIX sh, but dash seems to cope
with it, which is the major non-POSIX shell, and we have a couple
of instances in configure already. Still, why do we need these
variables to be local?)

Also some clang warnings:
  CC    tests/rcutorture.o
/Users/pm215/src/qemu/tests/rcutorture.c:260:13: warning: variable 'garbage' is
      uninitialized when used here [-Wuninitialized]
            garbage++;
            ^~~~~~~
/Users/pm215/src/qemu/tests/rcutorture.c:244:25: note: initialize the variable
      'garbage' to silence this warning
    volatile int garbage;
                        ^
                         = 0
1 warning generated.

And the rcutorture test seems to hang on OSX, or at least take way
longer than anything we put in 'make check' ought to take.

thanks
-- PMM