qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] block: change default for discard and write zer


From: Kevin Wolf
Subject: Re: [Qemu-devel] [PATCH] block: change default for discard and write zeroes to INT_MAX
Date: Mon, 2 Feb 2015 17:45:03 +0100
User-agent: Mutt/1.5.21 (2010-09-15)

Am 02.02.2015 um 17:25 hat Denis V. Lunev geschrieben:
> On 02/02/15 19:13, Kevin Wolf wrote:
> >Am 02.02.2015 um 15:48 hat Peter Lieven geschrieben:
> >>do not trim requests if the driver does not supply a limit
> >>through BlockLimits. For write zeroes we still keep a limit
> >>for the unsupported path to avoid allocating a big bounce buffer.
> >>
> >>Suggested-by: Kevin Wolf <address@hidden>
> >>Suggested-by: Denis V. Lunev <address@hidden>
> >>Signed-off-by: Peter Lieven <address@hidden>
> >Thanks, applied to the block branch (and removed 'block/raw-posix: set
> >max_write_zeroes to INT_MAX for regular files' from the queue).
> >
> >Kevin
> double checked the code.
> 
> There are 2 things to patch for discard, write_zeroes is OK for me.
> Sorry, for not paying attention for discard branch :(

Good catch, thanks!

But shouldn't we use the actual limits instead of INT_MAX, i.e. SIZE_MAX
for gluster and UINT32_MAX for nbd?

Kevin



reply via email to

[Prev in Thread] Current Thread [Next in Thread]