[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 17/19] qtest/ahci: Add a macro bootup routine
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH 17/19] qtest/ahci: Add a macro bootup routine |
|
Date: |
Tue, 03 Feb 2015 09:53:30 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
On 02/02/2015 22:12, John Snow wrote:
>
> It comes in handy later for testing migration so I don't have to do a
> lot of boilerplate for each instance, though it is just a convenience
> subroutine with no logic of its own.
>
> I like to cut down on boilerplate as much as possible to expose the
> logic of the test as much as possible.
>
> Have a suggestion for a better name, or are you very adamant about
> culling it?
I'm adamant about culling it because I don't have a suggestion for a
better name.
In the long run, I think we should just have a qos_boot function that
does everything including PCI scanning, mapping BARs and initializing
devices. But we're of course very far from that.
Paolo