[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 6/9] s390x/kvm: unknown DIAGNOSE code should give a s
From: |
Cornelia Huck |
Subject: |
[Qemu-devel] [PULL 6/9] s390x/kvm: unknown DIAGNOSE code should give a specification exception |
Date: |
Tue, 3 Feb 2015 14:08:45 +0100 |
From: Christian Borntraeger <address@hidden>
As described in CP programming services an unimplemented DIAGNOSE
function should return a specification exception. Today we give the
guest an operation exception.
As both exception types are suppressing and Linux as a guest does not
care about the type of program check in its exception table handler
as long as both types have the same kind of error handling (nullifying,
terminating, suppressing etc.) this was unnoticed.
Reviewed-by: Thomas Huth <address@hidden>
Signed-off-by: Christian Borntraeger <address@hidden>
Signed-off-by: Cornelia Huck <address@hidden>
---
target-s390x/kvm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target-s390x/kvm.c b/target-s390x/kvm.c
index 6bf2719..6f2d5b4 100644
--- a/target-s390x/kvm.c
+++ b/target-s390x/kvm.c
@@ -1091,7 +1091,7 @@ static int handle_diag(S390CPU *cpu, struct kvm_run *run,
uint32_t ipb)
break;
default:
DPRINTF("KVM: unknown DIAG: 0x%x\n", func_code);
- r = -1;
+ enter_pgmcheck(cpu, PGM_SPECIFICATION);
break;
}
--
1.7.9.5
- [Qemu-devel] [PULL 0/9] s390x bugfixes and cleanups, Cornelia Huck, 2015/02/03
- [Qemu-devel] [PULL 2/9] s390x/pci: avoid sign extension in stpcifc, Cornelia Huck, 2015/02/03
- [Qemu-devel] [PULL 1/9] s390: Plug memory leak on s390_pci_generate_event() error path, Cornelia Huck, 2015/02/03
- [Qemu-devel] [PULL 3/9] s390x/pci: check for invalid function handle, Cornelia Huck, 2015/02/03
- [Qemu-devel] [PULL 4/9] s390x/pci: fix dma notifications in rpcit instruction, Cornelia Huck, 2015/02/03
- [Qemu-devel] [PULL 5/9] s390x/kvm: Fix diag-308 register decoding, Cornelia Huck, 2015/02/03
- [Qemu-devel] [PULL 7/9] s390x/ipl: Improved code indentation in s390_ipl_init(), Cornelia Huck, 2015/02/03
- [Qemu-devel] [PULL 9/9] pc-bios/s390-ccw: update binary, Cornelia Huck, 2015/02/03
- [Qemu-devel] [PULL 6/9] s390x/kvm: unknown DIAGNOSE code should give a specification exception,
Cornelia Huck <=
- [Qemu-devel] [PULL 8/9] pc-bios/s390-ccw: fix sparse warnings, Cornelia Huck, 2015/02/03
- Re: [Qemu-devel] [PULL 0/9] s390x bugfixes and cleanups, Peter Maydell, 2015/02/03
- Re: [Qemu-devel] [PULL 0/9] s390x bugfixes and cleanups, Peter Maydell, 2015/02/03