[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 1/6] onenand: g_malloc() can't fail, bury dead er
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH v2 1/6] onenand: g_malloc() can't fail, bury dead error handling |
Date: |
Wed, 4 Feb 2015 11:26:02 +0100 |
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Gonglei <address@hidden>
---
hw/block/onenand.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/hw/block/onenand.c b/hw/block/onenand.c
index 348630d..1b2c893 100644
--- a/hw/block/onenand.c
+++ b/hw/block/onenand.c
@@ -346,15 +346,9 @@ static inline int onenand_prog_spare(OneNANDState *s, int
sec, int secn,
static inline int onenand_erase(OneNANDState *s, int sec, int num)
{
uint8_t *blankbuf, *tmpbuf;
+
blankbuf = g_malloc(512);
- if (!blankbuf) {
- return 1;
- }
tmpbuf = g_malloc(512);
- if (!tmpbuf) {
- g_free(blankbuf);
- return 1;
- }
memset(blankbuf, 0xff, 512);
for (; num > 0; num--, sec++) {
if (s->blk_cur) {
--
1.9.3
- [Qemu-devel] [PATCH v2 0/6] Trivial cleanups around g_malloc(), Markus Armbruster, 2015/02/04
- [Qemu-devel] [PATCH v2 3/6] kvm: g_malloc() can't fail, bury dead error handling, Markus Armbruster, 2015/02/04
- [Qemu-devel] [PATCH v2 2/6] rtl8139: g_malloc() can't fail, bury dead error handling, Markus Armbruster, 2015/02/04
- [Qemu-devel] [PATCH v2 6/6] translate-all: Use g_try_malloc() for dynamic translator buffer, Markus Armbruster, 2015/02/04
- [Qemu-devel] [PATCH v2 5/6] vnc: g_realloc() can't fail, bury dead error handling, Markus Armbruster, 2015/02/04
- [Qemu-devel] [PATCH v2 4/6] rdma: g_malloc0() can't fail, bury dead error handling, Markus Armbruster, 2015/02/04
- [Qemu-devel] [PATCH v2 1/6] onenand: g_malloc() can't fail, bury dead error handling,
Markus Armbruster <=
- Re: [Qemu-devel] [PATCH v2 0/6] Trivial cleanups around g_malloc(), Michael Tokarev, 2015/02/08