Re: [Qemu-devel] [PATCH] xilinx_ethlite: Clean up after commit 2f991ad

[Peter Crosthwaite]

On Wed, Jan 21, 2015 at 5:18 AM, Markus Armbruster <address@hidden> wrote:
> The "fall through" added by the commit is clearly intentional.  Mark
> it so.  Hushes up Coverity.
>
> Signed-off-by: Markus Armbruster <address@hidden>

Reviewed-by: Peter Crosthwaite <address@hidden>

> ---
>  hw/net/xilinx_ethlite.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/hw/net/xilinx_ethlite.c b/hw/net/xilinx_ethlite.c
> index 9536f64..ad6b553 100644
> --- a/hw/net/xilinx_ethlite.c
> +++ b/hw/net/xilinx_ethlite.c
> @@ -146,6 +146,7 @@ eth_write(void *opaque, hwaddr addr,
>              if (!(value & CTRL_S)) {
>                  qemu_flush_queued_packets(qemu_get_queue(s->nic));
>              }
> +            /* fall through */
>          case R_TX_LEN0:
>          case R_TX_LEN1:
>          case R_TX_GIE0:
> --
> 1.9.3
>
>