qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH RFC v3 1/6] qemu-iotests: fix tests 067, 071 and


From: Max Reitz
Subject: Re: [Qemu-devel] [PATCH RFC v3 1/6] qemu-iotests: fix tests 067, 071 and 087
Date: Wed, 04 Feb 2015 12:45:41 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0

On 2015-02-04 at 04:32, Xiao Guang Chen wrote:
From: Xiao Guang Chen <address@hidden>

Update the output files for test case 067, 071 and 087 because qemu option
-nodefaults was used to start a guest so there are no default floppy and
cdrom for guests any more.
Use virtio-blk instead of virtio-blk-pci as the device driver for test case
067. For virtio-blk-pci is the same with virtio-blk as device driver but
other platform such as s390 may not recognize the virtio-blk-pci.

Reviewed-by:   Michael Mueller <address@hidden>
Signed-off-by: Xiao Guang Chen <address@hidden>
---
  tests/qemu-iotests/067     |  8 ++++----
  tests/qemu-iotests/067.out | 26 +++++++++-----------------
  tests/qemu-iotests/071.out | 12 ++++--------
  tests/qemu-iotests/087.out | 18 +++---------------
  4 files changed, 20 insertions(+), 44 deletions(-)

First of all, this patch needs to be rebased (it doesn't apply on qemu's current master branch any more (without manual fixing)).

Second, I think this patch belongs after patch 3 (or should be squashed into it, considering that commits should not break tests), because as it is here, it breaks these tests on x86.

Max



reply via email to

[Prev in Thread] Current Thread [Next in Thread]