Re: [Qemu-devel] [PATCH v2 04/19] libqos/ahci: Add command header helpers

[Stefan Hajnoczi]

On Tue, Feb 03, 2015 at 04:46:24PM -0500, John Snow wrote:
> @@ -432,5 +433,11 @@ void start_ahci_device(AHCIQState *ahci);
>  void ahci_hba_enable(AHCIQState *ahci);
>  unsigned ahci_port_select(AHCIQState *ahci);
>  void ahci_port_clear(AHCIQState *ahci, uint8_t px);
> +void ahci_get_command_header(AHCIQState *ahci, uint8_t px,
> +                             uint8_t cx, AHCICommandHeader *cmd);
> +void ahci_set_command_header(AHCIQState *ahci, uint8_t px,
> +                             uint8_t cx, AHCICommandHeader *cmd);
> +void ahci_destroy_command(AHCIQState *ahci, uint8_t px, uint8_t cx);
> +unsigned ahci_pick_cmd(AHCIQState *ahci, uint8_t px);

"px" and "cx" are cryptic names.  "port" and "cmd_slot" would be
clearer.

pgppSYFmTJ1VY.pgp
Description: PGP signature