Re: [Qemu-devel] [PATCH v2 12/19] libqos/ahci: add ahci command functions

[Stefan Hajnoczi]

On Tue, Feb 03, 2015 at 04:46:32PM -0500, John Snow wrote:
> This patch adds the AHCICommand structure, and a set of functions to
> operate on the structure.
> 
> ahci_command_create - Initialize and create a new AHCICommand in memory
> ahci_command_free - Destroy this object.
> ahci_command_set_buffer - Set where the guest memory DMA buffer is.
> ahci_command_commit - Write this command to the AHCI HBA.
> ahci_command_issue - Issue the committed command synchronously.
> ahci_command_issue_async - Issue the committed command asynchronously.
> ahci_command_wait - Wait for an asynchronous command to finish.
> ahci_command_slot - Get the number of the command slot we committed to.
> 
> Helpers:
> size_to_prdtl       - Calculate the required minimum PRDTL size from
>                       a buffer size.
> ahci_command_find   - Given an ATA command mnemonic, look it up in the
>                       properties table to obtain info about the command.
> command_header_init - Initialize the command header with sane values.
> command_table_init  - Initialize the command table with sane values.
> 
> Signed-off-by: John Snow <address@hidden>
> ---
>  tests/ahci-test.c   |  73 +++++--------------
>  tests/libqos/ahci.c | 202 
> ++++++++++++++++++++++++++++++++++++++++++++++++++++
>  tests/libqos/ahci.h |  15 ++++
>  3 files changed, 234 insertions(+), 56 deletions(-)

Reviewed-by: Stefan Hajnoczi <address@hidden>

pgpHwaAtHvHGx.pgp
Description: PGP signature