[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v4 06/16] block/xen: Use blk_new_open() in blk_conne
From: |
Max Reitz |
Subject: |
[Qemu-devel] [PATCH v4 06/16] block/xen: Use blk_new_open() in blk_connect() |
Date: |
Thu, 5 Feb 2015 13:58:15 -0500 |
As part of the required changes, this fixes a bug where specifying an
invalid driver would result in the block layer probing the image format;
now it will result in an error, unless "<unset>" is specified as the
driver name. Fixing this would require further work on the xen_disk code
which does not seem worth it (at this point and for this patch).
Signed-off-by: Max Reitz <address@hidden>
---
hw/block/xen_disk.c | 27 +++++++++++----------------
1 file changed, 11 insertions(+), 16 deletions(-)
diff --git a/hw/block/xen_disk.c b/hw/block/xen_disk.c
index 21842a0..267d8a8 100644
--- a/hw/block/xen_disk.c
+++ b/hw/block/xen_disk.c
@@ -40,6 +40,8 @@
#include "xen_blkif.h"
#include "sysemu/blockdev.h"
#include "sysemu/block-backend.h"
+#include "qapi/qmp/qdict.h"
+#include "qapi/qmp/qstring.h"
/* ------------------------------------------------------------- */
@@ -897,30 +899,23 @@ static int blk_connect(struct XenDevice *xendev)
blkdev->dinfo = drive_get(IF_XEN, 0, index);
if (!blkdev->dinfo) {
Error *local_err = NULL;
- BlockBackend *blk;
- BlockDriver *drv;
- BlockDriverState *bs;
+ QDict *options = NULL;
- /* setup via xenbus -> create new block driver instance */
- xen_be_printf(&blkdev->xendev, 2, "create new bdrv (xenbus setup)\n");
- blk = blk_new_with_bs(blkdev->dev, NULL);
- if (!blk) {
- return -1;
+ if (strcmp(blkdev->fileproto, "<unset>")) {
+ options = qdict_new();
+ qdict_put(options, "driver", qstring_from_str(blkdev->fileproto));
}
- blkdev->blk = blk;
- bs = blk_bs(blk);
- drv = bdrv_find_whitelisted_format(blkdev->fileproto, readonly);
- if (bdrv_open(&bs, blkdev->filename, NULL, NULL, qflags,
- drv, &local_err) != 0) {
+ /* setup via xenbus -> create new block driver instance */
+ xen_be_printf(&blkdev->xendev, 2, "create new bdrv (xenbus setup)\n");
+ blkdev->blk = blk_new_open(blkdev->dev, blkdev->filename, NULL,
options,
+ qflags, &local_err);
+ if (!blkdev->blk) {
xen_be_printf(&blkdev->xendev, 0, "error: %s\n",
error_get_pretty(local_err));
error_free(local_err);
- blk_unref(blk);
- blkdev->blk = NULL;
return -1;
}
- assert(bs == blk_bs(blk));
} else {
/* setup via qemu cmdline -> already setup for us */
xen_be_printf(&blkdev->xendev, 2, "get configured bdrv (cmdline
setup)\n");
--
2.1.0
- Re: [Qemu-devel] [PATCH v4 01/16] block: Lift some BDS functions to the BlockBackend, (continued)
- [Qemu-devel] [PATCH v4 05/16] blockdev: Use blk_new_open() in blockdev_init(), Max Reitz, 2015/02/05
- [Qemu-devel] [PATCH v4 03/16] block: Add Error parameter to bdrv_find_protocol(), Max Reitz, 2015/02/05
- [Qemu-devel] [PATCH v4 07/16] qemu-img: Use blk_new_open() in img_open(), Max Reitz, 2015/02/05
- [Qemu-devel] [PATCH v4 06/16] block/xen: Use blk_new_open() in blk_connect(),
Max Reitz <=
- [Qemu-devel] [PATCH v4 08/16] qemu-img: Use blk_new_open() in img_rebase(), Max Reitz, 2015/02/05
- [Qemu-devel] [PATCH v4 12/16] qemu-io: Remove "growable" option, Max Reitz, 2015/02/05
- [Qemu-devel] [PATCH v4 02/16] block: Add blk_new_open(), Max Reitz, 2015/02/05
- [Qemu-devel] [PATCH v4 09/16] qemu-img: Use BlockBackend as far as possible, Max Reitz, 2015/02/05