Re: [Qemu-devel] [PATCH v4 05/16] blockdev: Use blk_new_open() in blockdev_init()

[Eric Blake]

On 02/05/2015 11:58 AM, Max Reitz wrote:
> Due to different error propagation, this breaks tests 051 and 087; fix
> their output.
> 
> Signed-off-by: Max Reitz <address@hidden>
> ---
>  blockdev.c                 | 92 
> +++++++++++++++++++++-------------------------
>  tests/qemu-iotests/051.out | 62 +++++++++++++++----------------
>  tests/qemu-iotests/087.out |  8 ++--
>  3 files changed, 77 insertions(+), 85 deletions(-)
> 

>  
>  Testing: -drive file=TEST_DIR/t.qcow2,driver=qcow2,format=qcow2
> -QEMU_PROG: -drive file=TEST_DIR/t.qcow2,driver=qcow2,format=qcow2: could not 
> open disk image TEST_DIR/t.qcow2: Driver specified twice
> +QEMU_PROG: -drive file=TEST_DIR/t.qcow2,driver=qcow2,format=qcow2: Cannot 
> specify both 'driver' and 'format'

This one is a nice improvement; I'm glad we added the test in 4/16.

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature