[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 12/16] qemu-io: Remove "growable" option
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v4 12/16] qemu-io: Remove "growable" option |
Date: |
Thu, 05 Feb 2015 14:15:54 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
On 02/05/2015 11:58 AM, Max Reitz wrote:
> Remove "growable" option from the "open" command and from the qemu-io
> command line. qemu-io is about to be converted to BlockBackend which
> will make sure that no request exceeds the image size, so the only way
> to keep "growable" would be to use BlockBackend if it is not given and
> to directly access the BDS if it is.
>
> qemu-io is a debugging tool, therefore removing a rarely used option
> will have only a very small impact, if any. There was only one
> qemu-iotest which used the option; since it is not critical, this patch
> just removes it.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> qemu-io.c | 23 +++------------
> tests/qemu-iotests/016 | 73
> ----------------------------------------------
> tests/qemu-iotests/016.out | 23 ---------------
> tests/qemu-iotests/group | 2 +-
> 4 files changed, 5 insertions(+), 116 deletions(-)
> delete mode 100755 tests/qemu-iotests/016
> delete mode 100644 tests/qemu-iotests/016.out
>
> +++ b/tests/qemu-iotests/group
> @@ -22,7 +22,7 @@
> 013 rw auto
> 014 rw auto
> 015 rw snapshot auto
> -016 rw auto quick
> +# 016 was removed, do not reuse
Works for me.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v4 07/16] qemu-img: Use blk_new_open() in img_open(), (continued)
- [Qemu-devel] [PATCH v4 07/16] qemu-img: Use blk_new_open() in img_open(), Max Reitz, 2015/02/05
- [Qemu-devel] [PATCH v4 06/16] block/xen: Use blk_new_open() in blk_connect(), Max Reitz, 2015/02/05
- [Qemu-devel] [PATCH v4 08/16] qemu-img: Use blk_new_open() in img_rebase(), Max Reitz, 2015/02/05
- [Qemu-devel] [PATCH v4 12/16] qemu-io: Remove "growable" option, Max Reitz, 2015/02/05
- Re: [Qemu-devel] [PATCH v4 12/16] qemu-io: Remove "growable" option,
Eric Blake <=
- [Qemu-devel] [PATCH v4 02/16] block: Add blk_new_open(), Max Reitz, 2015/02/05
- [Qemu-devel] [PATCH v4 09/16] qemu-img: Use BlockBackend as far as possible, Max Reitz, 2015/02/05
- [Qemu-devel] [PATCH v4 14/16] block: Clamp BlockBackend requests, Max Reitz, 2015/02/05
- [Qemu-devel] [PATCH v4 10/16] qemu-nbd: Use blk_new_open() in main(), Max Reitz, 2015/02/05
- [Qemu-devel] [PATCH v4 11/16] qemu-io: Use blk_new_open() in openfile(), Max Reitz, 2015/02/05