Re: [Qemu-devel] [PATCH] rtl8139: simplify timer logic

[Stefan Hajnoczi]

On Tue, Jan 20, 2015 at 03:44:59PM +0100, Paolo Bonzini wrote:
> Pavel Dovgalyuk reports that TimerExpire and the timer are not restored
> correctly on the receiving end of migration.
> 
> It is not clear to me whether this is really the case, but we can take
> the occasion to get rid of the complicated code that computes PCSTimeout
> on the fly upon changes to IntrStatus/IntrMask.  Just always keep a
> timer running, it will fire every ~130 seconds at most if the interrupt
> is masked with TimerInt != 0.
> 
> This makes rtl8139_set_next_tctr_time idempotent (when the virtual clock
> is stopped between two calls, as is the case during migration).
> 
> Tested with Frediano's qtest.
> 
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
>  hw/net/rtl8139.c | 77 
> ++++++++++++++++++++------------------------------------
>  1 file changed, 27 insertions(+), 50 deletions(-)

Thanks, applied to my net tree:
https://github.com/stefanha/qemu/commits/net

Stefan

pgp76TsOo4DVJ.pgp
Description: PGP signature