[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] openpic: convert to vmstate
From: |
Juan Quintela |
Subject: |
Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] openpic: convert to vmstate |
Date: |
Mon, 09 Feb 2015 14:50:03 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) |
Mark Cave-Ayland <address@hidden> wrote:
> On 09/02/15 12:43, Alexander Graf wrote:
> Ha! I did actually do this but I accidentally messed up a rebase just
> before sending out the patchset so it got lost. But yes, I agree a
> version bump to 3 should be sufficient here.
>
> Just to put this in context: before the PPC loadvm/savevm patchset was
> posted to the list, I was bisecting down to around the 0.10-0.11
> timeframe to figure out where things broke, and even then the Mac
> machines wouldn't run correctly after loadvm. So I agree with Alex that
> any snapshots this old would be useless anyway.
>
> Based upon this, are there any other changes you would like before a respin?
I didn't knew that it was completely broken (TM).
As said in a different email, I think that using the _EQUAL() macro for
nb_cpus is a good idea. For the rest, I agree with it.
Later, Juan.
Re: [Qemu-devel] [Qemu-ppc] [PATCH 0/2] openpic: convert to vmstate, Alexander Graf, 2015/02/06