[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 28/37] blockdev: Add blockdev-insert-medium
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 28/37] blockdev: Add blockdev-insert-medium |
Date: |
Mon, 09 Feb 2015 15:23:14 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
On 02/09/2015 10:11 AM, Max Reitz wrote:
> And a helper function for that which directly takes a pointer to the BDS
reads better with s/that/that,/
> to be inserted instead of its node-name (which will be used for
> implementing 'change' using blockdev-insert-medium).
>
> Signed-off-by: Max Reitz <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> ---
> blockdev.c | 43 +++++++++++++++++++++++++++++++++++++++++++
> qapi/block-core.json | 17 +++++++++++++++++
> qmp-commands.hx | 37 +++++++++++++++++++++++++++++++++++++
> 3 files changed, 97 insertions(+)
But a grammar nit in the commit message doesn't invalidate R-b :)
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 27/37] blockdev: Add blockdev-remove-medium, (continued)
- [Qemu-devel] [PATCH v2 27/37] blockdev: Add blockdev-remove-medium, Max Reitz, 2015/02/09
- [Qemu-devel] [PATCH v2 33/37] hmp: Use blockdev-change-medium for change command, Max Reitz, 2015/02/09
- [Qemu-devel] [PATCH v2 36/37] iotests: More options for VM.add_drive(), Max Reitz, 2015/02/09
- [Qemu-devel] [PATCH v2 31/37] block: Inquire tray state before tray-moved events, Max Reitz, 2015/02/09
- [Qemu-devel] [PATCH v2 32/37] qmp: Introduce blockdev-change-medium, Max Reitz, 2015/02/09
- [Qemu-devel] [PATCH v2 35/37] hmp: Add read-only-mode option to change command, Max Reitz, 2015/02/09
- [Qemu-devel] [PATCH v2 37/37] iotests: Add test for change-related QMP commands, Max Reitz, 2015/02/09
- [Qemu-devel] [PATCH v2 23/37] blockdev: Allow more options for BB-less BDS tree, Max Reitz, 2015/02/09
- [Qemu-devel] [PATCH v2 28/37] blockdev: Add blockdev-insert-medium, Max Reitz, 2015/02/09
- Re: [Qemu-devel] [PATCH v2 28/37] blockdev: Add blockdev-insert-medium,
Eric Blake <=
- [Qemu-devel] [PATCH v2 30/37] blockdev: Implement change with basic operations, Max Reitz, 2015/02/09
- [Qemu-devel] [PATCH v2 29/37] blockdev: Implement eject with basic operations, Max Reitz, 2015/02/09
- [Qemu-devel] [PATCH v2 20/37] block: Prepare for NULL BDS, Max Reitz, 2015/02/09
- [Qemu-devel] [PATCH v2 26/37] blockdev: Add blockdev-close-tray, Max Reitz, 2015/02/09
- [Qemu-devel] [PATCH v2 25/37] blockdev: Add blockdev-open-tray, Max Reitz, 2015/02/09
- [Qemu-devel] [PATCH v2 12/37] block: Move BlockAcctStats into BlockBackend, Max Reitz, 2015/02/09