[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] checkpatch: port fix from kernel "## is not a v
From: |
Christian Borntraeger |
Subject: |
Re: [Qemu-devel] [PATCH] checkpatch: port fix from kernel "## is not a valid modifier" |
Date: |
Tue, 10 Feb 2015 09:07:16 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
Am 09.02.2015 um 23:54 schrieb Peter Maydell:
> On 9 February 2015 at 19:43, Christian Borntraeger
> <address@hidden> wrote:
>> From: Andy Whitcroft <address@hidden>
>>
>> checkpatch currently loops on fpu/softfloat.c
>> Turns out this is fixed in the Linux version of checkpatch.
>>
>> So this is a port of Andy Whitcrofts fix from Linux,
>> Original commit was commit 89a883530fe7 ("checkpatch: ## is not a
>> valid modifier")
>>
>> Cc: Andy Whitcroft <address@hidden>
>> Signed-off-by: Christian Borntraeger <address@hidden>
>> ---
>> scripts/checkpatch.pl | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
>> index 5df61f9..8635f4c 100755
>> --- a/scripts/checkpatch.pl
>> +++ b/scripts/checkpatch.pl
>> @@ -1061,7 +1061,9 @@ sub possible {
>> case|
>> else|
>> asm|__asm__|
>> - do
>> + do|
>> + \#|
>> + \#\#|
>
> Are you sure this line should end with a '|', given it's the
> last item in the alternation ?
Good question - dont know. But the kernel version looks the same.