[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/9] error: New convenience function error_repor
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 1/9] error: New convenience function error_report_err() |
Date: |
Tue, 10 Feb 2015 17:44:59 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
On 10/02/2015 17:34, Markus Armbruster wrote:
> I've typed error_report("%s", error_get_pretty(ERR)) too many times
> already, and I've fixed too many instances of qerror_report_err(ERR)
> to error_report("%s", error_get_pretty(ERR)) as well. Capture the
> pattern in a convenience function.
>
> Since it's almost invariably followed by error_free(), stuff that into
> the convenience function as well.
>
> Put it to use with this Coccinelle semantic patch:
For your "no good deed goes unpunished" record, can you prepare a Wiki
page on how to use Coccinelle? My attempts always saw it confused by
qemu/queue.h macros.
Paolo
- [Qemu-devel] [PATCH 0/9] Clean up around error_get_pretty(), qerror_report_err(), Markus Armbruster, 2015/02/10
- [Qemu-devel] [PATCH 3/9] monitor: Avoid qerror_report_err() outside QMP command handlers, Markus Armbruster, 2015/02/10
- [Qemu-devel] [PATCH 6/9] tpm: Avoid qerror_report_err() outside QMP command handlers, Markus Armbruster, 2015/02/10
- [Qemu-devel] [PATCH 2/9] monitor: Clean up around monitor_handle_fd_param(), Markus Armbruster, 2015/02/10
- [Qemu-devel] [PATCH 1/9] error: New convenience function error_report_err(), Markus Armbruster, 2015/02/10
- Re: [Qemu-devel] [PATCH 1/9] error: New convenience function error_report_err(),
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH 1/9] error: New convenience function error_report_err(), Markus Armbruster, 2015/02/11
- Re: [Qemu-devel] [PATCH 1/9] error: New convenience function error_report_err(), Eric Blake, 2015/02/10
[Qemu-devel] [PATCH 7/9] vl: Avoid qerror_report_err() outside QMP command handlers, Markus Armbruster, 2015/02/10
[Qemu-devel] [PATCH 5/9] numa: Avoid qerror_report_err() outside QMP command handlers, Markus Armbruster, 2015/02/10
[Qemu-devel] [PATCH 9/9] qemu-char: Avoid qerror_report_err() outside QMP command handlers, Markus Armbruster, 2015/02/10