[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 00/12] qcow2: Add new overlap check functions
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v3 00/12] qcow2: Add new overlap check functions |
Date: |
Tue, 10 Feb 2015 11:23:02 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
On 02/09/2015 12:25 PM, Max Reitz wrote:
> As has been requested, this series adds new overlap check functions to
> the qcow2 code. My local branch is called "qcow2-improved-overlap-v1",
> but I am not so sure whether it is actually an improvement; that is left
> for you to decide, dear reviewers.
>
> v3:
> - Patch 1:
> - s/few memory/little memory/ [Eric]
> - s/2014/2015/ [Eric]
> - s/of a or a/of or a/ [Eric]
> - Use nb_clusters_minus_one instead of nb_clusters, because
> nb_clusters == 0 is invalid [Eric]
> - Drop cached_windows_index [Stefan]
> - Reset current_nb_clusters to 1 when a new range starts in the
> algorithm which rebuilds the fragment list from the bitmap
> representation
> - Patch 3: Added a TODO comment that the user should be able to override
> the default cache size limit
> - Patch 8: As the patch "qcow2: Buffer L1 table in snapshot refcount
> update" has been dropped, this patch was changed to no longer rely on
> it
> - Patch 11: Replaced the size limit for a snapshot's L1 table by
> QCOW_MAX_L1_SIZE (was: INT_MAX / sizeof(uint64_t)) [Eric]
On this one, it was actually Stefan that spotted it.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v3 03/12] qcow2: Create metadata list, (continued)
- [Qemu-devel] [PATCH v3 08/12] qcow2/overlaps: Protect active L2 tables, Max Reitz, 2015/02/09
- [Qemu-devel] [PATCH v3 04/12] qcow2/overlaps: Protect image header, Max Reitz, 2015/02/09
- [Qemu-devel] [PATCH v3 12/12] qcow2: Use new metadata overlap check function, Max Reitz, 2015/02/09
- [Qemu-devel] [PATCH v3 09/12] qcow2/overlaps: Protect snapshot table, Max Reitz, 2015/02/09
- [Qemu-devel] [PATCH v3 10/12] qcow2/overlaps: Protect inactive L1 tables, Max Reitz, 2015/02/09
- [Qemu-devel] [PATCH v3 11/12] qcow2/overlaps: Protect inactive L2 tables, Max Reitz, 2015/02/09
- Re: [Qemu-devel] [PATCH v3 00/12] qcow2: Add new overlap check functions,
Eric Blake <=
- Re: [Qemu-devel] [PATCH v3 00/12] qcow2: Add new overlap check functions, Max Reitz, 2015/02/27