Re: [Qemu-devel] [PATCH v12 03/17] block: Introduce bdrv_dirty_bitmap_granularity()

[Max Reitz]

On 2015-02-09 at 20:35, John Snow wrote:
> This returns the granularity (in bytes) of dirty bitmap,
> which matches the QMP interface and the existing query
> interface.
>
> Small adjustments are made to ensure that granularity-- in bytes--
> is handled consistently as a uint64_t throughout the code.

Just asking whether you want to adjust the following, too: "int 
granularity" in mirror_free_init() (the granularity is stored as an 64 
bit integer, but the value is limited by qmp_drive_mirror() to stay 
between 512 and 64M, and is defined to be a uint32_t by 
qapi/block-core.json).

It's fine from my perspective, so my R-b stands, but it looked like it 
might conflict with "is handled consistently". :-)

Max

> Signed-off-by: John Snow <address@hidden>
> ---
>   block.c               | 17 +++++++++++------
>   include/block/block.h |  3 ++-
>   2 files changed, 13 insertions(+), 7 deletions(-)