[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/2] qcow2: Respect new_block in alloc_refcount_
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 0/2] qcow2: Respect new_block in alloc_refcount_block() |
Date: |
Tue, 10 Feb 2015 15:19:33 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
On 02/10/2015 01:02 PM, Max Reitz wrote:
> Under certain circumstances, making the refcount table grow can result
> in leaking clusters. The first patch fixes at least some of those
> circumstances (maybe there are more, but these are the ones I am aware
> of), and the second patch adds a test case.
>
>
> Max Reitz (2):
> qcow2: Respect new_block in alloc_refcount_block()
> iotests: Add tests for refcount table growth
Series:
Reviewed-by: Eric Blake <address@hidden>
How'd you find the leak?
>
> block/qcow2-refcount.c | 16 ++++++-
> tests/qemu-iotests/121 | 102
> +++++++++++++++++++++++++++++++++++++++++++++
> tests/qemu-iotests/121.out | 23 ++++++++++
> tests/qemu-iotests/group | 1 +
> 4 files changed, 140 insertions(+), 2 deletions(-)
> create mode 100755 tests/qemu-iotests/121
> create mode 100644 tests/qemu-iotests/121.out
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature