[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 06/10] rocker: add new rocker switch device
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v6 06/10] rocker: add new rocker switch device |
Date: |
Wed, 11 Feb 2015 09:49:36 +0000 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Wed, Feb 04, 2015 at 10:54:17PM -0800, address@hidden wrote:
> diff --git a/default-configs/pci.mak b/default-configs/pci.mak
> index a186c39..a7f3278 100644
> --- a/default-configs/pci.mak
> +++ b/default-configs/pci.mak
> @@ -32,3 +32,4 @@ CONFIG_PCI_TESTDEV=y
> CONFIG_NVME_PCI=y
> CONFIG_SD=y
> CONFIG_SDHCI=y
> +CONFIG_ROCKER=y
> diff --git a/hw/net/Makefile.objs b/hw/net/Makefile.objs
> index ea93293..4f8e826 100644
> --- a/hw/net/Makefile.objs
> +++ b/hw/net/Makefile.objs
> @@ -35,3 +35,6 @@ obj-y += vhost_net.o
>
> obj-$(CONFIG_ETSEC) += fsl_etsec/etsec.o fsl_etsec/registers.o \
> fsl_etsec/rings.o fsl_etsec/miim.o
> +
> +common-obj-y += rocker/rocker.o rocker/rocker_fp.o rocker/rocker_desc.o \
> + rocker/rocker_world.o rocker/rocker_of_dpa.o
common-obj-y breaks builds for targets that do not support PCI. This
should be common-obj-$(CONFIG_ROCKER) instead.
This poses a new problem: when QEMU is built without rocker the QMP/HMP
commands fail to link because rocker_find() and friends are missing
(they live in rocker.c).
There are two options compile out the HMP/QMP commands (see how SPICE
does this, e.g. query-spice) or provide stub functions that return an
error to the HMP/QMP client when rocker is unavailable.
pgp2wIBLbOCGl.pgp
Description: PGP signature
- [Qemu-devel] [PATCH v6 04/10] pci: add rocker device ID, (continued)
- [Qemu-devel] [PATCH v6 04/10] pci: add rocker device ID, sfeldma, 2015/02/05
- [Qemu-devel] [PATCH v6 01/10] net: add MAC address string printer, sfeldma, 2015/02/05
- [Qemu-devel] [PATCH v6 09/10] MAINTAINERS: add rocker, sfeldma, 2015/02/05
- [Qemu-devel] [PATCH v6 07/10] qmp: add rocker device support, sfeldma, 2015/02/05
- [Qemu-devel] [PATCH v6 02/10] virtio-net: use qemu_mac_strdup_printf, sfeldma, 2015/02/05
- [Qemu-devel] [PATCH v6 03/10] rocker: add register programming guide, sfeldma, 2015/02/05
- [Qemu-devel] [PATCH v6 08/10] rocker: add tests, sfeldma, 2015/02/05
- [Qemu-devel] [PATCH v6 10/10] rocker: timestamp on the debug logs helps correlate with events in the VM, sfeldma, 2015/02/05
- [Qemu-devel] [PATCH v6 05/10] pci: add network device class 'other' for network switches, sfeldma, 2015/02/05
- [Qemu-devel] [PATCH v6 06/10] rocker: add new rocker switch device, sfeldma, 2015/02/05
- Re: [Qemu-devel] [PATCH v6 06/10] rocker: add new rocker switch device,
Stefan Hajnoczi <=