[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/3] Add migrate -u option for -incoming pause
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 2/3] Add migrate -u option for -incoming pause |
Date: |
Wed, 11 Feb 2015 10:10:29 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
On 02/11/2015 09:48 AM, Dr. David Alan Gilbert wrote:
>> Agree, a new command for QMP would be better (it serves as both the new
>> command to use, and the witness that the '-incoming pause:' command line
>> works). The HMP 'migrate -u' is just fine, though (it's fine to have a
>> single HMP command smart enough to call out to two different QMP commands).
>
> I've split it out as you all suggested; I made it migrate-incoming and
> also made an HMP migrate_incoming; although as you say you can merge them,
> I just find it easier when they match - if you're used to using an HMP
> command it's easier when you need to find the matching QMP command.
Fair enough; HMP exists for ease-of-use, so whichever way you found
easier to code is sufficient :)
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
[Qemu-devel] [PATCH 1/3] Add -incoming pause, Dr. David Alan Gilbert (git), 2015/02/10
[Qemu-devel] [PATCH 3/3] Document -incoming options, Dr. David Alan Gilbert (git), 2015/02/10