[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [v5 09/12] migration: Make compression co-work with xbz
From: |
Li, Liang Z |
Subject: |
Re: [Qemu-devel] [v5 09/12] migration: Make compression co-work with xbzrle |
Date: |
Thu, 12 Feb 2015 02:24:05 +0000 |
> Liang Li <address@hidden> wrote:
> > Now, multiple thread compression can co-work with xbzrle. when xbzrle
> > is on, multiple thread compression will only work at the first round
> > of RAM data sync.
> >
> > Signed-off-by: Liang Li <address@hidden>
> > Signed-off-by: Yang Zhang <address@hidden>
> > Reviewed-by: Dr.David Alan Gilbert <address@hidden>
>
> Drop this patch and just give an error when trying to set xbzrle and
> compression? User have to pick one and only one, no second guess him/her?
>
Live migration can benefit from compression co-work with xbzrle. You know,
xbzrle
transfer the raw RAM pages to destination in the ram bulk stage, and after
that, it transfers
the diff data. The ram bulk stage is where compression can do optimization, and
beside
the ram bulk stage, xbzrle may do better than compression in some situation. So
compression and xbzrle are not in conflict but complementary.
I think it's a pity if we limit the use to select only one of them. If there is
no strong reason,
I don't agree to drop this patch.
Liang
- [Qemu-devel] [v5 06/12] arch_init: Add and free data struct for decompression, (continued)
[Qemu-devel] [v5 10/12] migration: Add the core code for decompression, Liang Li, 2015/02/10
[Qemu-devel] [v5 11/12] migration: Add interface to control compression, Liang Li, 2015/02/10
[Qemu-devel] [v5 12/12] migration: Add commands to set and query parameter, Liang Li, 2015/02/10