[Qemu-devel] [PATCH RFC v3 16/27] COLO failover: Don't do failover during loading VM's state

[zhanghailiang]

Signed-off-by: zhanghailiang <address@hidden>
Signed-off-by: Li Zhijian <address@hidden>
Signed-off-by: Lai Jiangshan <address@hidden>
---
 migration/colo.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/migration/colo.c b/migration/colo.c
index bcde1ec..82459ec 100644
--- a/migration/colo.c
+++ b/migration/colo.c
@@ -60,6 +60,7 @@ enum {
 };
 
 static QEMUBH *colo_bh;
+static bool vmstate_loading;
 static Coroutine *colo;
 /* colo buffer */
 #define COLO_BUFFER_BASE_SIZE (1000*1000*4ULL)
@@ -80,7 +81,10 @@ static bool colo_runstate_is_stopped(void)
  */
 static void slave_do_failover(void)
 {
-    DPRINTF("do_failover!\n");
+    /* Wait for incoming thread loading vmstate */
+    while (vmstate_loading) {
+        ;
+    }
 
     colo = NULL;
 
@@ -114,6 +118,7 @@ static void master_do_failover(void)
 static bool failover_completed;
 void colo_do_failover(MigrationState *s)
 {
+    DPRINTF("do_failover!\n");
     /* Make sure vm stopped while failover */
     if (!colo_runstate_is_stopped()) {
         vm_stop_force_state(RUN_STATE_COLO);
@@ -485,12 +490,15 @@ void *colo_process_incoming_checkpoints(void *opaque)
         }
 
         qemu_mutex_lock_iothread();
+        vmstate_loading = true;
         if (qemu_loadvm_state(fb) < 0) {
             error_report("COLO: loadvm failed");
+            vmstate_loading = false;
             qemu_mutex_unlock_iothread();
             goto out;
         }
         DPRINTF("Finish load all vm state to cache\n");
+        vmstate_loading = false;
         qemu_mutex_unlock_iothread();
 
         ret = colo_ctl_put(ctl, COLO_CHECKPOINT_LOADED);
-- 
1.7.12.4