Re: [Qemu-devel] [PATCH] nbd: Fix overflow return value

[Fam Zheng]

On Thu, 02/12 06:21, Yik Fang wrote:
> The value of reply.error should be the type unsigned int.
> 
> Signed-off-by: Yik Fang <address@hidden>
> ---
>  nbd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/nbd.c b/nbd.c
> index e56afbc1..30e2f3b 100644
> --- a/nbd.c
> +++ b/nbd.c
> @@ -1295,7 +1295,7 @@ static void nbd_trip(void *opaque)
>      default:
>          LOG("invalid request type (%u) received", request.type);
>      invalid_request:
> -        reply.error = -EINVAL;
> +        reply.error = EINVAL;
>      error_reply:
>          if (nbd_co_send_reply(req, &reply, 0) < 0) {
>              goto out;
> -- 
> 1.8.5
> 

Reviewed-by: Fam Zheng <address@hidden>